[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733577#comment-14733577
]
ASF GitHub Bot commented on FLINK-2626:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138277939
Yes, I don't see any advantage in having this overload. I would also change
`add(long value)` and `add(int value)` into `add(Long value)` and `add(Integer
value)` for consistency (I actually prefer primitive types, too; however, for
this case class types seems to be more appropriate because the inherited
methods use `Double` as parameter and as return type in `getLocalValue()`).
But you should wait for @StephanEwen feedback before chancing anything. I
am new to accumulators...
> Add a AverageAccumulator for FLINK-Accumulator
> ----------------------------------------------
>
> Key: FLINK-2626
> URL: https://issues.apache.org/jira/browse/FLINK-2626
> Project: Flink
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.10
> Reporter: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add a AverageAccumulator for Flink-Accumulator to calculate the average of
> values.
> The feature is like Storm-MultiReducedMetric.
> Feature in detail:
> 1.This class is named AverageAccumulator(any suggestion? I`m not good at
> English name) and implements SimpleAccumulator.
> 2.This class support long, integer and double input.
> 3.This class will return a double value as the average when the method
> getLocalValue() called.
> 4.Member method description:
> * add():
> A variety of add() method to support different inputs(e.g. Double, double,
> Long, long, Integer, int).
> It will add the input value and make the count + 1 each time.
> * public Double getLocalValue():
> To return the sum of value dividing count as average and the result will be
> "double".
> * public void resetLocal():
> To reset the value and count.
> It won`t be called automatically and it will be better to call this every
> time the getLocalValue() method called.
> * public void merge(Accumulator<Double, Double> other):
> To merge another accumulator(only support AverageAccumulator).
> * public AverageAccumulator clone():
> To return the whole current AverageAccumulator class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
