StefanRRichter commented on a change in pull request #8442: [FLINK-12483]
Support (legacy) SourceFunction as special case in the mailbox model for stream
tasks
URL: https://github.com/apache/flink/pull/8442#discussion_r283891510
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -130,4 +164,33 @@ public boolean triggerCheckpoint(CheckpointMetaData
checkpointMetaData, Checkpoi
}
}
}
+
+ /**
+ * Runnable that executes the the source function in the head operator.
+ */
+ private class LegacySourceFunctionThread extends Thread {
+
+ private Throwable sourceExecutionThrowable;
Review comment:
It is not required to be volatile because we only evaluate it from a
different thread after calling `join()` which guarantees visibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
