StefanRRichter commented on a change in pull request #8442: [FLINK-12483]
Support (legacy) SourceFunction as special case in the mailbox model for stream
tasks
URL: https://github.com/apache/flink/pull/8442#discussion_r284579615
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -98,12 +100,44 @@ protected void cleanup() {
}
@Override
- protected void run() throws Exception {
- headOperator.run(getCheckpointLock(),
getStreamStatusMaintainer());
+ protected void performDefaultAction(ActionContext context) throws
Exception {
+ // Against the usual contract of this method, this
implementation is not step-wise but blocking instead for
Review comment:
I was thinking about that, but then 1) how the you add the synchronization
part around `run()` and 2) it would still loop around the defaultAction, but
starting the thread should then be ignored? I think this is actually cleaner
and more performant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
