StefanRRichter commented on a change in pull request #8442: [FLINK-12483]
Support (legacy) SourceFunction as special case in the mailbox model for stream
tasks
URL: https://github.com/apache/flink/pull/8442#discussion_r285587317
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -98,12 +100,44 @@ protected void cleanup() {
}
@Override
- protected void run() throws Exception {
- headOperator.run(getCheckpointLock(),
getStreamStatusMaintainer());
+ protected void performDefaultAction(ActionContext context) throws
Exception {
+ // Against the usual contract of this method, this
implementation is not step-wise but blocking instead for
Review comment:
I was thinking through the alternatives and they have all more downsides in
my opinion, performance wise and from the required modifications.
Now the "nice" thing about this compatibility layer is that we can play kind
of the same trick when we remove the `SourceStreamTask` - we should always be
able to just send runnables that fireup the source thread and hijack the
mailbox. Question is then where and when to emit those in a nice way, but I
think technially it is possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
