azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r287362596
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
##########
@@ -322,29 +325,24 @@ public void run() {
*/
@Test
public void testRequestBackoffConfiguration() throws Exception {
- ResultPartitionID[] partitionIds = new ResultPartitionID[] {
- new ResultPartitionID(),
- new ResultPartitionID(),
- new ResultPartitionID()
+ IntermediateResultPartitionID[] partitionIds = new
IntermediateResultPartitionID[] {
+ new IntermediateResultPartitionID(),
+ new IntermediateResultPartitionID(),
+ new IntermediateResultPartitionID()
};
- InputChannelDeploymentDescriptor[] channelDescs = new
InputChannelDeploymentDescriptor[]{
+ ResourceID localLocation = new ResourceID("local");
+ ShuffleDeploymentDescriptor[] channelDescs = new
ShuffleDeploymentDescriptor[]{
// Local
- new InputChannelDeploymentDescriptor(
- partitionIds[0],
- ResultPartitionLocation.createLocal()),
+ createSddWithLocalConnection(partitionIds[0],
localLocation, 10000),
// Remote
- new InputChannelDeploymentDescriptor(
- partitionIds[1],
- ResultPartitionLocation.createRemote(new
ConnectionID(new InetSocketAddress("localhost", 5000), 0))),
+ createSddWithLocalConnection(partitionIds[1], new
ResourceID("remote"), 5000),
Review comment:
refactored to `ShuffleDeploymentDescriptorBuilder`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
