azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r287609955
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -300,6 +302,9 @@
// ------ Fields that are only relevant for archived execution graphs
------------
private String jsonPlan;
+ /** Shuffle master to register partitions for task deployment. */
+ private final ShuffleMaster shuffleMaster =
DefaultShuffleMaster.getInstance();
Review comment:
At the moment the default implementation is hardcoded anyways. I suggest we
consider it when we introduce configuration and proper creation of shuffle
components as one of final steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
