azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce 
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r287611055
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
 ##########
 @@ -272,4 +272,18 @@ private InputGate createInputGate(
                        return gates[0];
                }
        }
+
+       private static ShuffleDeploymentDescriptor 
createLocalSdd(ResultPartitionID resultPartitionID, ResourceID location) {
 
 Review comment:
   we can also use `NettyShuffleDescriptorBuilder` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to