tillrohrmann commented on a change in pull request #8608: 
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291164278
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
 ##########
 @@ -228,6 +227,7 @@ public void 
releasePartitions(Collection<ResultPartitionID> partitionIds) {
         * @return collection of partitions which still occupy some resources 
locally on this task executor
         * and have been not released yet.
         */
 
 Review comment:
   `Overriden` methods usually don't need additional JavaDocs unless they do 
something different than the interface method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to