tillrohrmann commented on a change in pull request #8608:
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291189466
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -246,13 +252,16 @@ public static TaskManagerServices fromConfiguration(
// start the I/O manager, it will create some temp directories.
final IOManager ioManager = new
IOManagerAsync(taskManagerServicesConfiguration.getTmpDirPaths());
- final NetworkEnvironment network = NetworkEnvironment.create(
+ final ShuffleEnvironment shuffleEnvironment =
NettyShuffleEnvironment.fromConfiguration(
Review comment:
Can't we keep the `NettyShuffleEnvironmentConfiguration` part of the
`TaskManagerServicesConfiguration`? I think in the future we will need a
`ShuffleEnvironmentConfiguration` which we pass to the
`ShuffleEnvironmentFactory` once the `ShuffleEnvironment` is pluggable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
