tillrohrmann commented on a change in pull request #8608:
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291185737
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -367,12 +365,14 @@ public static TaskExecutor startTaskManager(
taskManagerServicesConfiguration.getSystemResourceMetricsProbingInterval());
TaskManagerServices taskManagerServices =
TaskManagerServices.fromConfiguration(
+ configuration,
Review comment:
I deliberately created the `TaskManagerServicesConfiguration` in order to
not having to pass in the `Configuration` object to this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
