tillrohrmann commented on a change in pull request #8608:
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291163457
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -66,12 +68,13 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * Network I/O components of each {@link TaskExecutor} instance. The network
environment contains
- * the data structures that keep track of all intermediate results and all
data exchanges.
+ * The implementation of {@link ShuffleEnvironment} based on netty network
communication, local memory and disk files.
+ * The network environment contains the data structures that keep track of all
intermediate results
+ * and shuffle data exchanges.
Review comment:
Maybe add that this implementation supports `BLOCKING` as well as
`PIPELINED` data exchanges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
