zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297236152
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironmentBuilder.java
##########
@@ -55,7 +54,9 @@
private MetricGroup metricGroup =
UnregisteredMetricGroups.createUnregisteredTaskManagerMetricGroup();
- private IOManager ioManager = new IOManagerAsync();
+ private final String tempDir =
EnvironmentInformation.getTemporaryFileDirectory();
+
+ private String[] tempDirs = new String[] {tempDir};
Review comment:
The `tempDirs` could be reset in builder, so it could not be defined final
here. Do you think it is necessary for define static for both `tempDir` and
`tempDirs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
