zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297584342
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionTest.java
##########
@@ -99,8 +93,8 @@ ResultSubpartition createFailingWritesSubpartition() throws
Exception {
//
------------------------------------------------------------------------
- static Path tmpPath() throws IOException {
- return new File(TMP_DIR.newFolder(), "subpartition").toPath();
+ static Path tmpPath() {
+ return
fileChannelManager.createChannel().getPathFile().toPath();
Review comment:
It seems a bit redundant for having both `fileChannelManager` and `TMP_DIR`
meanwhile for the same function. I am not sure whether only this change would
bring conflicts, because we also change the other parts of this class. If you
confirm, I could revert this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
