zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297588192
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/sort/ExternalSortLargeRecordsITCase.java
##########
@@ -71,7 +71,7 @@ public void beforeTest() {
}
@After
- public void afterTest() {
+ public void afterTest() throws Exception {
this.ioManager.close();
if (!this.ioManager.isProperlyShutDown()) {
Review comment:
Yes, it might involve in many tests.
Actually my first version was ignoring any exceptions thrown by
`IOManager#close`, and @azagrebin suggested ignoring only `IOException` and
throwing any unexpected exceptions outside to make quickly fail.
Actually I think these two options both work on my side. If we revert to
previous behavior, we did not change anything during refactoring, otherwise we
changed the behavior as now to do as we think in more proper way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
