pnowojski commented on a change in pull request #8621:
[FLINK-12682][connectors] StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8621#discussion_r297581797
##########
File path:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/StringWriterTest.java
##########
@@ -32,7 +32,7 @@
@Test
public void testDuplicate() {
Review comment:
Please also add a unit test (in this file?) to cover that the custom
delimiter is actually used somehow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
