pnowojski commented on a change in pull request #8621: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8621#discussion_r300413608
########## File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java ########## @@ -40,12 +40,18 @@ private transient Charset charset; + private String rowDelimiter; + + private static final String DEFAULT_ROW_DELIMITER = "\n"; + + private byte[] rowDelimiterBytes; + /** * Creates a new {@code StringWriter} that uses {@code "UTF-8"} charset to convert * strings to bytes. */ public StringWriter() { - this("UTF-8"); + this("UTF-8", "\n"); Review comment: nit: You can keep this line as it was before (`this("UTF-8")`) to avoid small code duplication. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services