pnowojski commented on a change in pull request #8621:
[FLINK-12682][connectors] StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8621#discussion_r297580610
##########
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java
##########
@@ -54,13 +59,15 @@ public StringWriter() {
*
* @param charsetName Name of the charset to be used, must be valid
input for {@code Charset.forName(charsetName)}
*/
- public StringWriter(String charsetName) {
+ public StringWriter(String charsetName, String rowDelimiter) {
Review comment:
please update the `@param` java doc.
Secondly, I'm not sure, but isn't `StringWriter` a part of public API and
shouldn't we preserve the old constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
