twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309174185
########## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/FlinkSqlDataTypeSpec.java ########## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser; + +import org.apache.flink.sql.parser.type.ExtendedSqlType; +import org.apache.flink.sql.parser.type.SqlArrayType; +import org.apache.flink.sql.parser.type.SqlBytesType; +import org.apache.flink.sql.parser.type.SqlMapType; +import org.apache.flink.sql.parser.type.SqlMultiSetType; +import org.apache.flink.sql.parser.type.SqlRowType; +import org.apache.flink.sql.parser.type.SqlStringType; +import org.apache.flink.sql.parser.type.SqlZonedTimeType; +import org.apache.flink.sql.parser.type.SqlZonedTimestampType; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.sql.SqlCollation; +import org.apache.calcite.sql.SqlDataTypeSpec; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlUtil; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.calcite.sql.type.SqlTypeUtil; +import org.apache.calcite.util.Util; + +import java.nio.charset.Charset; +import java.util.Objects; +import java.util.TimeZone; +import java.util.stream.Collectors; + +/** + * Represents a SQL data type specification in a parse tree. + * + * <p>A <code>SqlDataTypeSpec</code> is immutable; once created, you cannot + * change any of the fields.</p> + * + * <p>This class is an extension to {@link SqlDataTypeSpec}, we support + * complex type expressions like:</p> + * + * <blockquote><code>ROW(<br> + * NUMBER(5, 2) NOT NULL AS foo,<br> + * ROW(BOOLEAN AS b, MyUDT NOT NULL AS i) AS rec)</code></blockquote> + * + * <p>Until <a href="https://issues.apache.org/jira/browse/CALCITE-3213";>CALCITE-3213</a> + * is resolved, we can remove this class. + */ +public class FlinkSqlDataTypeSpec extends SqlDataTypeSpec { + // Flag saying if the element type is nullable if this type is a collection type. + // For collection type, we mean ARRAY and MULTISET type now. + private Boolean elementNullable; + + public FlinkSqlDataTypeSpec( + SqlIdentifier collectionsTypeName, + SqlIdentifier typeName, + int precision, + int scale, + String charSetName, + Boolean nullable, + Boolean elementNullable, + SqlParserPos pos) { + super(collectionsTypeName, typeName, precision, scale, + charSetName, null, nullable, pos); + this.elementNullable = elementNullable; + } + + public FlinkSqlDataTypeSpec( + SqlIdentifier collectionsTypeName, + SqlIdentifier typeName, + int precision, + int scale, + String charSetName, + TimeZone timeZone, + Boolean nullable, + Boolean elementNullable, + SqlParserPos pos) { + super(collectionsTypeName, typeName, precision, scale, + charSetName, timeZone, nullable, pos); + this.elementNullable = elementNullable; + } + + public FlinkSqlDataTypeSpec( + SqlIdentifier typeName, + int precision, + int scale, + String charSetName, + TimeZone timeZone, + Boolean nullable, + Boolean elementNullable, + SqlParserPos pos) { + super(null, typeName, precision, scale, + charSetName, timeZone, nullable, pos); + this.elementNullable = elementNullable; + } + + @Override + public SqlNode clone(SqlParserPos pos) { + return (getCollectionsTypeName() != null) + ? new FlinkSqlDataTypeSpec(getCollectionsTypeName(), getTypeName(), getPrecision(), + getScale(), getCharSetName(), getNullable(), this.elementNullable, pos) + : new FlinkSqlDataTypeSpec(getTypeName(), getPrecision(), getScale(), + getCharSetName(), getTimeZone(), getNullable(), this.elementNullable, pos); + } + + /** Returns a copy of this data type specification with a given + * nullability. */ + @Override + public SqlDataTypeSpec withNullable(Boolean nullable) { + if (Objects.equals(nullable, this.getNullable())) { + return this; + } + return new FlinkSqlDataTypeSpec(getCollectionsTypeName(), getTypeName(), + getPrecision(), getScale(), getCharSetName(), getTimeZone(), nullable, + this.elementNullable, getParserPosition()); + } + + @Override + public RelDataType deriveType(RelDataTypeFactory typeFactory) { + // Default to be nullable. + return this.deriveType(typeFactory, true); + } + + @Override + public void unparse(SqlWriter writer, int leftPrec, int rightPrec) { + final SqlIdentifier typeName = getTypeName(); + String name = typeName.getSimple(); + if (typeName instanceof ExtendedSqlType) { + typeName.unparse(writer, leftPrec, rightPrec); + } else if (SqlTypeName.get(name) != null) { + SqlTypeName sqlTypeName = SqlTypeName.get(name); + writer.keyword(name); + if (sqlTypeName.allowsPrec() && this.getPrecision() >= 0) { + SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.FUN_CALL, "(", ")"); + writer.print(this.getPrecision()); + if (sqlTypeName.allowsScale() && this.getScale() >= 0) { + writer.sep(",", true); + writer.print(this.getScale()); + } + + writer.endList(frame); + } + + if (this.getCharSetName() != null) { + writer.keyword("CHARACTER SET"); + writer.identifier(this.getCharSetName(), false); + } + + if (this.getCollectionsTypeName() != null) { + // Fix up nullable attribute if this is a collection type. + if (elementNullable != null && !elementNullable) { + writer.keyword("NOT NULL"); + } + writer.keyword(this.getCollectionsTypeName().getSimple()); + } + } else if (name.startsWith("_")) { + writer.keyword(name.substring(1)); + } else { + this.getTypeName().unparse(writer, leftPrec, rightPrec); + } + if (getNullable() != null && !getNullable()) { + writer.keyword("NOT NULL"); + } + } + + @Override + public RelDataType deriveType(RelDataTypeFactory typeFactory, boolean nullable) { + final SqlIdentifier typeName = getTypeName(); + if (!typeName.isSimple()) { + return null; + } + final String name = typeName.getSimple(); + final SqlTypeName sqlTypeName = SqlTypeName.get(name); + // Try to get Flink custom data type first. + RelDataType type = getExtendedType(typeFactory, typeName); + if (type == null) { + if (sqlTypeName == null) { + return null; + } else { + // NOTE jvs 15-Jan-2009: earlier validation is supposed to + // have caught these, which is why it's OK for them + // to be assertions rather than user-level exceptions. + final int precision = getPrecision(); + final int scale = getScale(); + if ((precision >= 0) && (scale >= 0)) { + assert sqlTypeName.allowsPrecScale(true, true); + type = typeFactory.createSqlType(sqlTypeName, precision, scale); + } else if (precision >= 0) { + assert sqlTypeName.allowsPrecNoScale(); + type = typeFactory.createSqlType(sqlTypeName, precision); + } else { + assert sqlTypeName.allowsNoPrecNoScale(); + type = typeFactory.createSqlType(sqlTypeName); + } + } + } + + if (SqlTypeUtil.inCharFamily(type)) { + // Applying Syntax rule 10 from SQL:99 spec section 6.22 "If TD is a + // fixed-length, variable-length or large object character string, + // then the collating sequence of the result of the <cast + // specification> is the default collating sequence for the + // character repertoire of TD and the result of the <cast + // specification> has the Coercible coercibility characteristic." + SqlCollation collation = SqlCollation.COERCIBLE; Review comment: Remove these lines? Charsets and collations should not be part of Flink as mentioned in FLIP-37. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
