twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser]
Align the SQL CREATE TABLE DDL with FLIP-37
URL: https://github.com/apache/flink/pull/9243#discussion_r310000332
##########
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##########
@@ -367,53 +375,299 @@ SqlDrop SqlDropView(Span s, boolean replace) :
}
}
+SqlIdentifier FlinkCollectionsTypeName() :
+{
+}
+{
+ LOOKAHEAD(2)
+ <MULTISET> {
+ return new SqlIdentifier(SqlTypeName.MULTISET.name(), getPos());
+ }
+|
+ <ARRAY> {
+ return new SqlIdentifier(SqlTypeName.ARRAY.name(), getPos());
+ }
+}
+
+SqlIdentifier FlinkTypeName() :
+{
+ final SqlTypeName sqlTypeName;
+ final SqlIdentifier typeName;
+ final Span s = Span.of();
+}
+{
+ (
+<#-- additional types are included here -->
+<#-- make custom data types in front of Calcite core data types -->
+<#list parser.flinkDataTypeParserMethods as method>
+ <#if (method?index > 0)>
+ |
+ </#if>
+ LOOKAHEAD(2)
+ typeName = ${method}
+</#list>
+ |
+ LOOKAHEAD(2)
+ sqlTypeName = SqlTypeName(s) {
+ typeName = new SqlIdentifier(sqlTypeName.name(), s.end(this));
+ }
+ |
+ LOOKAHEAD(2)
+ typeName = FlinkCollectionsTypeName()
+ |
+ typeName = CompoundIdentifier() {
+ throw new ParseException("UDT in DDL is not supported yet.");
Review comment:
Agreed, but please open an issue also in Flink to track the support. It is
very confusing for users if data types are only available in certain SQL
locations. Users don't understand the difference between DDL and DQL. Esp. with
the introduction of computed columns it gets more confusing because special
cases like `STRING` would be available in DDL but not in the `CAST` of the
computed column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
