twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser]
Align the SQL CREATE TABLE DDL with FLIP-37
URL: https://github.com/apache/flink/pull/9243#discussion_r310108126
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/SqlRowType.java
##########
@@ -51,6 +55,10 @@ public SqlRowType(SqlParserPos pos,
return fieldTypes;
}
+ public List<SqlCharStringLiteral> getComments() {
Review comment:
@danny0405 We need to document all of that. I think we need to mark the DDL
as beta for now. There are too many limitations. I hope we can it into a better
shape in 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
