haodang commented on a change in pull request #10000: [FLINK-14398][SQL/Legacy
Planner]Further split input unboxing code into separate methods
URL: https://github.com/apache/flink/pull/10000#discussion_r340089928
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -574,13 +584,14 @@ class MatchCodeGenerator(
private def generateMeasurePatternVariableExp(patternName: String):
GeneratedPatternList = {
val listName = newName("patternEvents")
+ reusableMemberStatements.add(s"java.util.List $listName = new
java.util.ArrayList();")
val code = if (patternName == ALL_PATTERN_VARIABLE) {
addReusablePatternNames()
val patternTerm = newName("pattern")
j"""
- |java.util.List $listName = new java.util.ArrayList();
+ |$listName.clear();
Review comment:
On the test coverage, I think this test should have covered it, because our
change is executed with the rest of the code split:
https://github.com/haodang/flink/blob/hdang/split_input_unboxing_exprs/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream/sql/MatchRecognizeITCase.scala#L139
Let me know if you think we should add another test to target our change in
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
