haodang commented on a change in pull request #10000: [FLINK-14398][SQL/Legacy
Planner]Further split input unboxing code into separate methods
URL: https://github.com/apache/flink/pull/10000#discussion_r340090729
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -574,13 +584,14 @@ class MatchCodeGenerator(
private def generateMeasurePatternVariableExp(patternName: String):
GeneratedPatternList = {
val listName = newName("patternEvents")
+ reusableMemberStatements.add(s"java.util.List $listName = new
java.util.ArrayList();")
val code = if (patternName == ALL_PATTERN_VARIABLE) {
addReusablePatternNames()
val patternTerm = newName("pattern")
j"""
- |java.util.List $listName = new java.util.ArrayList();
+ |$listName.clear();
Review comment:
About `$listName = new java.util.ArrayList();` and things can be buffered
downstream, that's a good point, I'll make the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
