haodang commented on a change in pull request #10000: [FLINK-14398][SQL/Legacy
Planner]Further split input unboxing code into separate methods
URL: https://github.com/apache/flink/pull/10000#discussion_r340094625
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
##########
@@ -870,6 +871,45 @@ class SqlITCase extends StreamingWithStateTestBase {
assertEquals(List(expected.toString()), StreamITCase.testResults.sorted)
}
+
+ @Test
+ def testProjectionWithManyColumns(): Unit = {
+
+ val env = StreamExecutionEnvironment.getExecutionEnvironment
+ val tEnv = StreamTableEnvironment.create(env)
+ StreamITCase.clear
+
+ // force code split
+ tEnv.getConfig.setMaxGeneratedCodeLength(1)
Review comment:
makes sense that functionally it will be the same after removing this
explicit setup.
i think we might want to explicitly set it so that this unit test does not
depend on the default value of `maxGeneratedCodeLength`, which hypothetically
can change, similarly to the test `testSelectExpressionWithSplitFromTable()`.
Plus, we don't have any perf issue adding this.
what do you think? i'm also okay to remove it if you see that's not an
issue, but think setting it explicitly is more resilient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
