zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342976963
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/OutputAvailabilitySampleableTask.java
##########
@@ -22,13 +22,13 @@
import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
/**
- * Task interface used by {@link StackTraceSampleService} for back pressure
tracking.
+ * Task interface used by {@link TaskBackPressureSampleService} for back
pressure tracking.
*/
-interface StackTraceSampleableTask {
+interface OutputAvailabilitySampleableTask {
Review comment:
Maybe call this class `BackPressureSampleableTask`. Also for the below
method `isAvailableForOutput` -> `isBackPressured`
We do not need to expose the detail way in the interface how to monitor the
back pressure. This interface only describes the task can be sampled for back
pressure, and the specific implementation can monitor the back pressure via
different ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
