zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342984468
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskOutputAvailabilitySampleableTaskAdapter.java
##########
@@ -26,18 +26,18 @@
import static java.util.Objects.requireNonNull;
/**
- * Adapts {@link Task} to {@link StackTraceSampleableTask}.
+ * Adapts {@link Task} to {@link OutputAvailabilitySampleableTask}.
*/
-class TaskStackTraceSampleableTaskAdapter implements StackTraceSampleableTask {
+class TaskOutputAvailabilitySampleableTaskAdapter implements
OutputAvailabilitySampleableTask {
Review comment:
We could simplify to make `Task` class implement
`BackPressureSampleableTask` directly, then to delete this class. Furthermore
we could remove `#isRunning` method from the interface, because task can judge
the state internally and return the boolean value via
`BackPressureSampleableTask#isBackPressured`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
