zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342971189
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureSampleCoordinator.java
##########
@@ -295,42 +292,30 @@ int getNumberOfPendingSamples() {
//
------------------------------------------------------------------------
/**
- * A pending stack trace sample, which collects stack traces and owns a
- * {@link StackTraceSample} promise.
+ * A pending task back pressure stats, which collects task back pressure
+ * ratio and owns a {@link BackPressureStats} promise.
*
* <p>Access pending sample in lock scope.
*/
- private static class PendingStackTraceSample {
+ private static class PendingTaskBackPressureStats {
Review comment:
Class naming consistent between `PendingTaskBackPressureStats` and
`BackPressureStats`. I mean whether to retain term `Task`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
