zhijiangW commented on a change in pull request #10616: [FLINK-15288] Starting
jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361383564
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
##########
@@ -56,14 +56,14 @@
" Its not possible to use this configuration key to
define port ranges.");
/**
- * Percentage of heap space to remove from containers (YARN / Mesos),
to compensate
+ * Percentage of heap space to remove from containers (YARN / Mesos/
Kubernetes), to compensate
* for other JVM memory usage.
*/
public static final ConfigOption<Float> CONTAINERIZED_HEAP_CUTOFF_RATIO
= ConfigOptions
Review comment:
My previous thought for this option was for all the containers including
`TaskExecutor`. But after reviewing the related codes I find it is only for
master container. The `TaskExecutor` container would never use it.
So maybe we can rename this option to limit the scope to make it more
clearly, but it is out of scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
