zhijiangW commented on a change in pull request #10616: [FLINK-15288] Starting
jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361386887
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesUtilsTest.java
##########
@@ -87,41 +88,43 @@ public void testGetJobManagerStartCommand() {
final Configuration cfg = new Configuration();
final String jmJvmOpts = "-DjmJvm";
+ final int jmMemoryAfterCutoff =
BootstrapTools.calculateHeapSize(jobManagerMem, cfg);
+ final String jmJvmMem = String.format("-Xms%dm -Xmx%dm",
jmMemoryAfterCutoff, jmMemoryAfterCutoff);
Review comment:
We can still make these two vars as class level, and then `jmJvmMem` is not
needed to pass into below `getJobManagerExpectedCommand` every time, because it
is actually never changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
