zhijiangW commented on a change in pull request #10616: [FLINK-15288] Starting
jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361389142
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesUtilsTest.java
##########
@@ -144,6 +147,15 @@ public void testGetJobManagerStartCommand() {
" " + mainClass + " " + mainClassArgs + " " +
jmLogRedirects,
getJobManagerStartCommand(cfg, true, true,
mainClassArgs));
+
cfg.setInteger(ResourceManagerOptions.CONTAINERIZED_HEAP_CUTOFF_MIN, 300);
Review comment:
I think this part seems a bit reductant, because it tries to verify the
internal implementation of `BootstrapTools#calculateHeapSize` which is not
brought by this PR.
IMO, this utility method should be verified completely when introduced first
time. If not, we should separately verify it in general, not only in kubernetes
case.
I am not strongly against if you prefer to adding it here, but another
concern is that can we somehow reuse `getJobManagerExpectedCommand` in
`assertEquals`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
