lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink… URL: https://github.com/apache/flink/pull/10625#issuecomment-569266869 @JingsongLi @bowenli86 I have updated to use writable OIs for constant arguments, so that we don't need to our own implementations of OIs. Please note: 1. Non-constant arguments still use java OIs, but I can also update that if you think we should be consistent. 2. Also added test for constant DATE and TIMESTAMP values and realized we need a shim for the `java -> writable` conversion. 3. I haven't removed the shim for getting constant OIs. Hopefully it makes review a little bit easier. Can do that if you think we're moving in the right direction.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
