TisonKun commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388860674
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -272,10 +267,9 @@ private void requestKubernetesPod() {
* Request new pod if pending pods cannot satisfy pending slot requests.
*/
private void requestKubernetesPodIfRequired() {
- final int requiredTaskManagerSlots =
getNumberRequiredTaskManagerSlots();
- final int pendingTaskManagerSlots = numPendingPodRequests *
numSlotsPerTaskManager;
+ final int requiredTaskManagers =
getNumberRequiredTaskManagers();
- if (requiredTaskManagerSlots > pendingTaskManagerSlots) {
+ if (requiredTaskManagers > numPendingPodRequests) {
Review comment:
I can see the return value of `startWorker` is `@return whether the resource
can be allocated`
If so, we should also return boolean in this method where false if we don't
request a new pod.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
