TisonKun commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388863553
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -527,10 +524,9 @@ private FinalApplicationStatus
getYarnStatus(ApplicationStatus status) {
* Request new container if pending containers cannot satisfy pending
slot requests.
*/
private void requestYarnContainerIfRequired() {
- int requiredTaskManagerSlots =
getNumberRequiredTaskManagerSlots();
- int pendingTaskManagerSlots = numPendingContainerRequests *
numSlotsPerTaskManager;
+ int requiredTaskManagers = getNumberRequiredTaskManagers();
- if (requiredTaskManagerSlots > pendingTaskManagerSlots) {
+ if (requiredTaskManagers > numPendingContainerRequests) {
Review comment:
ditto here as in `KubernetesResourceManager `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
