xintongsong commented on a change in pull request #11320: [FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager at the worker granularity. URL: https://github.com/apache/flink/pull/11320#discussion_r388861404
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/WorkerResourceSpec.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.resources.CPUResource; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.runtime.clusterframework.TaskExecutorProcessSpec; +import org.apache.flink.util.Preconditions; + +import java.util.Objects; + +/** + * Resource specification of a worker, mainly used by SlotManager requesting from ResourceManager. + */ +public class WorkerResourceSpec { Review comment: There was a discussion about whether reusing `TaskExecutorResourceSpec` in the design google doc. We have decided to not reuse it, and I'll quote what Till commented on the doc here. > TaskExecutorResourceSpec defines for me the resources of a TaskExecutor. The SlotManager on the other hand is only interested in a certain set of resources which happen to be the exact same set as TaskExecutorResourceSpec offers. However, the latter might evolve adding more resource specifications. Hence, by reusing TaskExecutorResourceSpec we would also couple the SlotManager to the TaskExecutor's resource specification which does not necessarily need to be the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
