igalshilman commented on a change in pull request #54: [FLINK-16515][docs]
Refactor statefun documentation for multi-language SDKs
URL: https://github.com/apache/flink-statefun/pull/54#discussion_r390260388
##########
File path: statefun-docs/docs/deployment_operations/packaging.rst
##########
@@ -28,14 +28,15 @@ The recommended deployment mode for Stateful Functions
applications is to build
This way, user code does not need to package any Apache Flink components.
The provided base image allows teams to package their applications with all
the necessary runtime dependencies quickly.
-Below is an example Dockerfile for building a Stateful Functions image for an
application called ``statefun-example``.
+Below is an example Dockerfile for building a Stateful Functions image with
both an :ref:`embedded module <embedded_module>` and a :ref:`remote module
<remote_module>` for an application called ``statefun-example``.
-.. code-block:: java
+.. code-block:: dockerfile
FROM statefun
RUN mkdir -p /opt/statefun/modules/statefun-example
COPY target/statefun-example*jar /opt/statefun/modules/statefun-example/
+ COPY module.yaml /opt/statefun/modules/remote/module.yaml
Review comment:
are you missing a `mkdir -p /opt/statefun/modules/remote` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
