pnowojski commented on a change in pull request #11403:
[FLINK-16316][operators] Implement new StreamOperatorBase as a replacement for
AbstractStreamOperator
URL: https://github.com/apache/flink/pull/11403#discussion_r394823900
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactory.java
##########
@@ -32,14 +30,13 @@
*
* @param <OUT> The output type of the operator
*/
-@Internal
+@PublicEvolving
public interface StreamOperatorFactory<OUT> extends Serializable {
/**
* Create the operator. Sets access to the context and the output.
*/
- <T extends StreamOperator<OUT>> T createStreamOperator(
- StreamTask<?, ?> containingTask, StreamConfig config,
Output<StreamRecord<OUT>> output);
+ <T extends StreamOperator<OUT>> T
createStreamOperator(StreamOperatorInitializer<OUT> initializer);
Review comment:
I agree and I don't remember what was the reason behind the template
argument here, maybe it was just some error that went under our radar when
reviewing/merging. Definitely trying to fix it is on my to do list.
Currently I would lean towards option 2. But I don't want to change status
quo right know, as the PR is already pretty big and I don't know if that will
not explode into some larger change/fix - especially that I'm not sure that
there might be some reason behind this construct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
