pnowojski commented on a change in pull request #11403:
[FLINK-16316][operators] Implement new StreamOperatorBase as a replacement for
AbstractStreamOperator
URL: https://github.com/apache/flink/pull/11403#discussion_r394850101
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/YieldingOperatorFactory.java
##########
@@ -17,10 +17,13 @@
package org.apache.flink.streaming.api.operators;
+import org.apache.flink.annotation.PublicEvolving;
+
/**
* An operator that needs access to the {@link MailboxExecutor} to yield to
downstream operators needs to be created
* through a factory implementing this interface.
*/
+@PublicEvolving
public interface YieldingOperatorFactory<OUT> extends
StreamOperatorFactory<OUT> {
Review comment:
That would contradict
```
// yielding operators cannot be chained to legacy sources
if (downStreamOperator instanceof YieldingOperatorFactory) {
// unfortunately the information that vertices have
been chained is not preserved at this point
return !getHeadOperator(upStreamVertex,
streamGraph).isStreamSource();
}
```
What do you think about having mixed pattern? Common parameters in
`StreamOperatorParameters`, and "special" or rare ones as decorators?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
