pnowojski commented on a change in pull request #11403:
[FLINK-16316][operators] Implement new StreamOperatorBase as a replacement for
AbstractStreamOperator
URL: https://github.com/apache/flink/pull/11403#discussion_r394828846
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactoryUtil.java
##########
@@ -57,7 +57,13 @@
((ProcessingTimeServiceAware)
operatorFactory).setProcessingTimeService(processingTimeService);
}
- OP op = operatorFactory.createStreamOperator(containingTask,
configuration, output);
+ // TODO: what to do with ProcessingTimeServiceAware?
+ OP op = operatorFactory.createStreamOperator(
+ new StreamOperatorInitializer<>(
+ containingTask,
+ configuration,
+ output,
+ processingTimeService));
Review comment:
> Note for that goal, we would need to get rid of SimpleOperatorFactory:
Once an operator has been created, it cannot go back into factory. If we need
to functionality, then I only see builder pattern as a clean solution, where
going back and forth between operator and operator builder is doable
`SimpleOperatorFactory` is not intended to make possible to go back and
forth between operators and factories, but just to provide backward compatible
class for transporting `SetupableStreamOperator` classes. Also as it's intended
to be removed in the future (we can do it as that's `PublicEvolving` API), in
the design let's assume `SimpleOperatorFactory` doesn't exist.
But @AHeise, what do you think we should do with
`ProcessingTimeServiceAware`? `@Deprecate` and mark it for removal? Or Should I
do it in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
