AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399252055
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -170,9 +173,14 @@
private final CompletableFuture<Void> closeFuture;
+ @Nullable
+ protected BufferReceivedListener bufferReceivedListener;
Review comment:
It's set as part of the construction but unfortunately quite far away from
the constructor invocation. So it cannot be final but it should be set before
the `InputGate` being used by network thread. So I'd refrain from using
volatile on the hot path. @zhijiangW WDYT (code is from him)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
