AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399238657
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
return Optional.of(new BufferAndAvailability(next,
moreAvailable, getSenderBacklog()));
}
+ @Override
+ public List<Buffer> getInflightBuffers(long checkpointId) throws
IOException {
+ final ArrayList<Buffer> inflightBuffers = new
ArrayList<>(receivedBuffers.size());
Review comment:
We can move construction inside the synchronized block.
I don't see how `size` could be negative as that would violate the
collection contract. `size` is also just a hint and does not need to be exact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
