AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399243343
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -318,14 +345,16 @@ public void assignExclusiveSegments() throws IOException
{
}
}
- public void setInputChannel(InputChannel inputChannel) {
- checkNotNull(inputChannel);
- IntermediateResultPartitionID partitionId =
inputChannel.getPartitionId().getPartitionId();
+ public void setInputChannels(InputChannel... channels) {
synchronized (requestLock) {
- if (inputChannels.put(partitionId, inputChannel) == null
+ System.arraycopy(channels, 0, this.channels, 0,
numberOfInputChannels);
Review comment:
It should be part of the constructor. The issue is that we have a cyclic
dependency `InputChannel` knows it's owning gate and the gate has a list of the
owned channels. Extracting the `setOwner` and do it the other way around would
not give us much.
But I'd add the check in here if it doesn't break to much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
