tillrohrmann commented on a change in pull request #11320: [FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager at the worker granularity. URL: https://github.com/apache/flink/pull/11320#discussion_r403054549
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java ########## @@ -207,6 +208,18 @@ public int getNumberFreeSlotsOf(InstanceID instanceId) { } @Override + public Map<WorkerResourceSpec, Integer> getPendingWorkerNums() { + final int pendingWorkerNum = (int) Math.ceil((double) pendingSlots.size() / numSlotsPerWorker); + if (pendingWorkerNum > 0) { + return Collections.singletonMap( + Preconditions.checkNotNull(defaultWorkerResourceSpec, + "There should never be pending slots/workers in standalone mode."), Review comment: I think this should not be necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services