tillrohrmann commented on a change in pull request #11320: 
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager 
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r401731886
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesResourceManagerFactory.java
 ##########
 @@ -80,4 +84,10 @@ public static KubernetesResourceManagerFactory 
getInstance() {
                        fatalErrorHandler,
                        resourceManagerMetricGroup);
        }
+
+       @Override
+       protected CPUResource getDefaultCpus(Configuration configuration) {
+               double fallback = 
configuration.getDouble(KubernetesConfigOptions.TASK_MANAGER_CPU);
 
 Review comment:
   Out of scope for this PR but at some point we should unify the different CPU 
options for different deployments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to