tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403056960
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -156,8 +156,8 @@ protected void
internalDeregisterApplication(ApplicationStatus finalStatus, @Nul
}
@Override
- public boolean startNewWorker(ResourceProfile resourceProfile) {
- LOG.info("Starting new worker with resource profile, {}",
resourceProfile);
+ public boolean startNewWorker(WorkerResourceSpec workerResourceSpec) {
+ LOG.info("Starting new worker with worker resource spec, {}",
workerResourceSpec);
requestKubernetesPod();
Review comment:
I guess that we need a check that the configured pod fulfills
`workerResourceSpec`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
