tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r404085816
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1206,8 +1206,12 @@ public Void retrievePayload(ResourceID resourceID) {
// Resource Management
//
------------------------------------------------------------------------
- protected int getNumberRequiredTaskManagerSlots() {
- return slotManager.getNumberPendingTaskManagerSlots();
+ protected int getNumberRequiredTaskManagers() {
+ return getPendingWorkerNums().values().stream().reduce(0,
Integer::sum);
Review comment:
If this is the entry point, then we can do the check there. The important
bit is to maintain the invariant that we do not start containers for
`WorkerResourceSpecs` which are larger than the container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
