tillrohrmann commented on a change in pull request #11320: 
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager 
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r404630795
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ##########
 @@ -1054,10 +1054,10 @@ protected abstract void internalDeregisterApplication(
         * Allocates a resource using the resource profile.
         *
         * @param resourceProfile The resource description
-        * @return Collection of {@link ResourceProfile} describing the 
launched slots
+        * @return whether the resource can be allocated
         */
        @VisibleForTesting
-       public abstract Collection<ResourceProfile> 
startNewWorker(ResourceProfile resourceProfile);
+       public abstract boolean startNewWorker(ResourceProfile resourceProfile);
 
 Review comment:
   Hmm, but with this API we will waste resources because the caller thinks it 
has started a worker of the specified size, right? An idea how to improve the 
situation is to let the `startNewWorker` method return the size of the 
container it has started. This would allow the caller to react to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to