XComp commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549678069
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TestingPhysicalSlotProvider.java
##########
@@ -85,13 +95,16 @@ private
TestingPhysicalSlotProvider(SlotSharingExecutionSlotAllocatorTest.Physic
void completePhysicalSlotFutureFor(
SlotRequestId slotRequestId,
AllocationID allocationID) {
- ResourceProfile resourceProfile =
requests.get(slotRequestId).getSlotProfile().getPhysicalSlotResourceProfile();
- SharedSlotTestingUtils.TestingPhysicalSlot physicalSlot = new
SharedSlotTestingUtils.TestingPhysicalSlot(
- allocationID,
- taskManagerLocation,
- taskManagerGateway,
- resourceProfile);
- responses.get(slotRequestId).complete(physicalSlot);
+ synchronized (lock) {
Review comment:
I removed the concurrency as part of a larger refactoring of the
`TestingPhysicalSlotProvider`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
