XComp commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549674166
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SchedulerTestingUtils.java
##########
@@ -136,6 +136,16 @@ public static DefaultSchedulerBuilder
newSchedulerBuilderWithSlotSharingExecutio
return newSchedulerBuilderWithSlotSharingExecutionSlotAllocator(
jobGraph,
new
TestingPhysicalSlotProvider(SlotSharingExecutionSlotAllocatorTest.PhysicalSlotFutureCompletionMode.SUCCESS),
+ allocationTimeout);
+ }
+
+ public static DefaultSchedulerBuilder
newSchedulerBuilderWithSlotSharingExecutionSlotAllocator(
Review comment:
~Would you prefer having factory methods with different parameter
combinations instead of using the Builder?~
I realized that we talked about different methods here. I switched back to
factory methods instead of builders in the most recent refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
