tillrohrmann commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549684014
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SchedulerTestingUtils.java
##########
@@ -136,6 +136,16 @@ public static DefaultSchedulerBuilder
newSchedulerBuilderWithSlotSharingExecutio
return newSchedulerBuilderWithSlotSharingExecutionSlotAllocator(
jobGraph,
new
TestingPhysicalSlotProvider(SlotSharingExecutionSlotAllocatorTest.PhysicalSlotFutureCompletionMode.SUCCESS),
+ allocationTimeout);
+ }
+
+ public static DefaultSchedulerBuilder
newSchedulerBuilderWithSlotSharingExecutionSlotAllocator(
Review comment:
No, a builder is better. I think the comment originates from going
through the commits in creation order and at this point in time there wasn't a
builder created yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
