Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r63509482
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -306,7 +303,7 @@ object GradientDescentL2 {
* The regularization function is `||w||_1` with `w` being the weight
vector.
*/
class GradientDescentL1 extends GradientDescent {
-
+ //TODO(skavulya): Pass regularization penalty as a parameter
--- End diff --
TODOs are always good to be resolved :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
