Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1985#issuecomment-219702326
Thanks for your contribution @skavulya. The changes look really good :-) I
especially like your thorough and clear documentation of the different loss
functions. Great work.
I had some minor comments. Once fixed, the PR should be good to be merged
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
